Refactor gui settings #314
Merged
+208
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… s3 or azure widget
…andled before the write
Ferelith-maker
requested review from
Dabnsky,
foodprocessor,
jfantinhardesty and
brayan-trejo
as code owners
Dabnsky
approved these changes
Oct 4, 2024
foodprocessor
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
Remove the code that uses QSettings for config settings and use an internal dictionary to pass values between widgets.
Refactor the MainFactor to use config functions class
Checklist
Related Issues